PMD Results
The following document contains the results of PMD 5.2.3.
Files
AEM Library API - com/icfolson/aem/library/api/page/PageManagerDecorator.java
| Violation | Line |
|---|---|
| Consider using varargs for methods or constructors which take an array the last parameter. | 161 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 178 |
AEM Library Core - com/icfolson/aem/library/core/link/builders/factory/LinkBuilderFactory.java
| Violation | Line |
|---|---|
| Useless parentheses. | 84 |
AEM Library Core - com/icfolson/aem/library/core/node/DelegateComponentNode.java
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 26–397 |
AEM Library Core - com/icfolson/aem/library/core/request/impl/DefaultComponentServletRequest.java
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; | 68 |
AEM Library Core - com/icfolson/aem/library/core/servlets/ImageServlet.java
| Violation | Line |
|---|---|
| Avoid using Literals in Conditional Statements | 169 |
| Avoid if (x != y) ..; else ..; | 182–186 |
| Avoid if (x != y) ..; else ..; | 194–198 |
| A method should have only one exit point, and that should be the last statement in the method | 195 |
| A method should have only one exit point, and that should be the last statement in the method | 211 |
| There is log block not surrounded by if | 229 |
AEM Library Core - com/icfolson/aem/library/core/servlets/datasource/AbstractOptionsDataSourceServlet.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.google.common.collect.Lists' | 6 |
AEM Library Core - com/icfolson/aem/library/core/servlets/optionsprovider/Option.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 32 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 34 |
AEM Library Core - com/icfolson/aem/library/core/servlets/paragraphs/ParagraphJsonServlet.java
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; | 89–97 |
| A method should have only one exit point, and that should be the last statement in the method | 127 |
| A method should have only one exit point, and that should be the last statement in the method | 136 |
| Avoid variables with short names like b | 273 |
| Document empty method | 283–285 |
| Parameter 'paramWriteListener' is not assigned and could be declared final | 283 |
AEM Library Models - com/icfolson/aem/library/models/annotations/ImageInject.java
| Violation | Line |
|---|---|
| Variables should start with a lowercase character, 'NAME' starts with uppercase character. | 21 |
| Variables should start with a lowercase character, 'SELF' starts with uppercase character. | 23 |
| Variables should start with a lowercase character, 'IMG_SELECTOR' starts with uppercase character. | 25 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'IMG_SELECTOR' is not final. | 25 |
AEM Library Models - com/icfolson/aem/library/models/annotations/InheritInject.java
| Violation | Line |
|---|---|
| Variables should start with a lowercase character, 'NAME' starts with uppercase character. | 21 |
AEM Library Models - com/icfolson/aem/library/models/annotations/LinkInject.java
| Violation | Line |
|---|---|
| Variables should start with a lowercase character, 'NAME' starts with uppercase character. | 21 |
AEM Library Models - com/icfolson/aem/library/models/annotations/ReferenceInject.java
| Violation | Line |
|---|---|
| Variables should start with a lowercase character, 'NAME' starts with uppercase character. | 33 |
AEM Library Models - com/icfolson/aem/library/models/annotations/TagInject.java
| Violation | Line |
|---|---|
| Variables should start with a lowercase character, 'NAME' starts with uppercase character. | 33 |